Skip to content

Conversation

@coolljt0725
Copy link
Member

Signed-off-by: Lei Jitang [email protected]

Link to Image ID defininion when it refer to Image ID in definition of Image JSON ,
and link to Image JSON when it refer configuration JSON in definition of Image ID to make
it more clear.

@wking
Copy link
Contributor

wking commented Sep 13, 2016

I didn't expect this to work with GitHub's filesystem browser, since
it mutates the names to user-content-image_json and the like [1]. But
they must have some magic to handle the translation, because 2 puts
my Firefox at the right place. So I'm not sure how portable the
translation is, but f9f6696 looks good to me.

[1]: $ curl -s https://github.com/coolljt0725/image-spec/blob/f9f6696052cb0f9c20241064f7a34f658253bdb6/serialization.md | grep image_json
Image JSON
Each image's ID is given by the SHA256 hash of its configuration JSON.
Since the configuration JSON that gets hashed references hashes of each layer in the image, this formulation of the ImageID makes images content-addresable.

@jonboulle
Copy link
Contributor

Needs a rebase.

@coolljt0725 coolljt0725 force-pushed the imagejson branch 2 times, most recently from ae780cb to 28743f6 Compare September 18, 2016 13:51
@coolljt0725
Copy link
Member Author

@jonboulle rebased

@wking
Copy link
Contributor

wking commented Sep 19, 2016 via email

@coolljt0725 coolljt0725 changed the title Add some links in serialization.md Add some links in config.md Sep 19, 2016
@vbatts
Copy link
Member

vbatts commented Sep 20, 2016

LGTM

Approved with PullApprove

@philips
Copy link
Contributor

philips commented Sep 21, 2016

Sorry, I stripped out all of the HTML in #333. And I personally don't feel these links add a ton of value and may break depending on how this doc is rendered.

@coolljt0725
Copy link
Member Author

@philips Add these links to make it more readable . The description of Image JSON reference a ImageID defined below, it's better to link to there.

@coolljt0725 coolljt0725 reopened this Sep 21, 2016
@wking
Copy link
Contributor

wking commented Sep 21, 2016

On Tue, Sep 20, 2016 at 11:20:43PM -0700, Lei Jitang wrote:

@philips Add these links to make it more readable . The description
of Image JSON reference a ImageID defined below, it's better to
link to there.

You can link there with the Markdown in #333 (e.g. 1). I suggest
re-closing this PR in favor of #333.

@coolljt0725
Copy link
Member Author

@wking I hope #333 could included this :)

@wking
Copy link
Contributor

wking commented Sep 21, 2016

On Tue, Sep 20, 2016 at 11:55:58PM -0700, Lei Jitang wrote:

@wking I hope #333 could included this :)

#333 already adds the anchors. I've filed [1,2] asking for the links
themselves.

wking added a commit to wking/image-spec that referenced this pull request Sep 27, 2016
Originally proposed by Lei Jitang in 28743f6 (Add some links in
config.md, 2016-09-18, opencontainers#301) and not carried by opencontainers#333 [1].

[1]: opencontainers#333 (comment)

Signed-off-by: W. Trevor King <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants