-
Notifications
You must be signed in to change notification settings - Fork 775
Add some links in config.md #301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I didn't expect this to work with GitHub's filesystem browser, since [1]: $ curl -s https://github.com/coolljt0725/image-spec/blob/f9f6696052cb0f9c20241064f7a34f658253bdb6/serialization.md | grep image_json |
|
Needs a rebase. |
ae780cb to
28743f6
Compare
|
@jonboulle rebased |
Signed-off-by: Lei Jitang <[email protected]>
|
28743f6 still looks good to me.
|
|
Sorry, I stripped out all of the HTML in #333. And I personally don't feel these links add a ton of value and may break depending on how this doc is rendered. |
|
@philips Add these links to make it more readable . The description of |
|
On Tue, Sep 20, 2016 at 11:20:43PM -0700, Lei Jitang wrote:
You can link there with the Markdown in #333 (e.g. 1). I suggest |
Originally proposed by Lei Jitang in 28743f6 (Add some links in config.md, 2016-09-18, opencontainers#301) and not carried by opencontainers#333 [1]. [1]: opencontainers#333 (comment) Signed-off-by: W. Trevor King <[email protected]>
Signed-off-by: Lei Jitang [email protected]
Link to
Image IDdefininion when it refer toImage IDin definition ofImage JSON,and link to
Image JSONwhen it referconfiguration JSONin definition ofImage IDto makeit more clear.